working on win32 uwp! and libremidi update

include/libremidi/backends/pipewire/midi_out.hpp

@@ -24,8 +24,17 @@ public:
   midi_out_pipewire(output_configuration&& conf, pipewire_output_configuration&& apiconf)
       : configuration{std::move(conf), std::move(apiconf)}
   {
-    create_context(*this);
-    create_filter(*this);
+    if (auto ret = create_context(*this); ret != stdx::error{})
+    {
+      client_open_ = ret;
+      return;
+    }
+    if (auto ret = create_filter(*this); ret != stdx::error{})
+    {
+      client_open_ = ret;
+      return;
+    }
+    client_open_ = stdx::error{};
   }
 
   ~midi_out_pipewire() override
@@ -34,47 +43,46 @@ public:
     do_close_port();
     destroy_filter(*this);
     destroy_context();
-  }
-
-  void set_client_name(std::string_view) override
-  {
-    warning(configuration, "midi_out_pipewire: set_client_name unsupported");
+    client_open_ = std::errc::not_connected;
   }
 
   libremidi::API get_current_api() const noexcept override { return libremidi::API::PIPEWIRE; }
 
-  bool open_port(const output_port& out_port, std::string_view name) override
+  stdx::error open_port(const output_port& out_port, std::string_view name) override
   {
-    if (!create_local_port(*this, name, SPA_DIRECTION_OUTPUT))
-      return false;
+    if (auto err = create_local_port(*this, name, SPA_DIRECTION_OUTPUT); err != stdx::error{})
+      return err;
 
     this->filter->set_port_buffer(configuration.output_buffer_size);
 
-    if (!link_ports(*this, out_port))
-      return false;
+    if (auto err = link_ports(*this, out_port); err != stdx::error{})
+      return err;
 
     start_thread();
-    return true;
+    return stdx::error{};
   }
 
-  bool open_virtual_port(std::string_view name) override
+  stdx::error open_virtual_port(std::string_view name) override
   {
-    if (!create_local_port(*this, name, SPA_DIRECTION_OUTPUT))
-      return false;
+    if (auto err = create_local_port(*this, name, SPA_DIRECTION_OUTPUT); err != stdx::error{})
+      return err;
 
     this->filter->set_port_buffer(configuration.output_buffer_size);
 
     start_thread();
-    return true;
+    return stdx::error{};
   }
 
-  void close_port() override
+  stdx::error close_port() override
   {
     stop_thread();
-    do_close_port();
+    return do_close_port();
   }
 
-  void set_port_name(std::string_view port_name) override { rename_port(port_name); }
+  stdx::error set_port_name(std::string_view port_name) override
+  {
+    return rename_port(port_name);
+  }
 
   int process(spa_io_position* pos)
   {
@@ -120,6 +128,8 @@ public:
       if (res == -ENOSPC)
         break;
 
+      // Recycle the memory
+      m_gcqueue.enqueue(std::move(m));
       m_queue.pop();
     }
     spa_pod_builder_pop(&build, &f);
@@ -141,9 +151,14 @@ public:
     return 0;
   }
 
-  void send_message(const unsigned char* message, size_t size) override
+  stdx::error send_message(const unsigned char* message, size_t size) override
   {
-    m_queue.enqueue(libremidi::message(midi_bytes{message, message + size}, 0));
+    libremidi::message m;
+    m_gcqueue.try_dequeue(m);
+    m.bytes.assign(message, message + size);
+    m.timestamp = 0;
+    m_queue.enqueue(std::move(m));
+    return stdx::error{};
   }
 
   int convert_timestamp(int64_t user) const noexcept
@@ -159,13 +174,15 @@ public:
     }
   }
 
-  void schedule_message(int64_t ts, const unsigned char* message, size_t size) override
+  stdx::error schedule_message(int64_t ts, const unsigned char* message, size_t size) override
   {
     m_queue.enqueue(
         libremidi::message(midi_bytes{message, message + size}, convert_timestamp(ts)));
+    return stdx::error{};
   }
 
   moodycamel::ReaderWriterQueue<libremidi::message> m_queue;
+  moodycamel::ReaderWriterQueue<libremidi::message> m_gcqueue;
   std::atomic_int64_t m_process_clock = 0;
 };
 }